Correctly set certificate status for audit certs when regenerating. #11427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter-fogg
force-pushed
the
peter-fogg/fix-audit-cert-regen
branch
from
ce7a7fd
to
6427b12
Compare
| # analytics. Only do this if the certificate is new, or | ||
| # already marked as ineligible -- we don't want to mark | ||
| # existing audit certs as ineligible. | ||
| if (created or cert.status in (CertificateStatuses.audit_passing, CertificateStatuses.audit_notpassing)) \ |
There was a problem hiding this comment.
NIT: Prefer using parens instead of \ for multiline conditionals
|
One small comment. Up to you to resolve 👍 |
peter-fogg
force-pushed
the
peter-fogg/fix-audit-cert-regen
branch
from
6427b12
to
87f7c2f
Compare
|
Fair enough -- I switched it to parens. I'll merge once tests pass. |
peter-fogg
force-pushed
the
peter-fogg/fix-audit-cert-regen
branch
from
87f7c2f
to
711e2e7
Compare
|
I'm having trouble getting Pylint to accept the parens version, so I may just leave it with the backslash. ¯_(ツ)_/¯ |
peter-fogg
pushed a commit
that referenced
this pull request
Feb 4, 2016
Correctly set certificate status for audit certs when regenerating.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COR-2403
@bderusha